fix: guard nullable workbench/page access before dereferencing#1389
Merged
joaodinissf merged 1 commit intoJun 1, 2026
Merged
Conversation
Two UI helpers walked workbench.getActiveWorkbenchWindow().getActivePage()... chains with no null checks, NPEing when there is no active window/page/editor: - PlatformPluginAwareEditorOpener.open(): the page lookup was even outside the try, so the NPE escaped the IDE.openEditor error handling. Guard getActiveWorkbenchWindow() (matching the sibling getProjectName()); fall back to the super.open() result when null. - CheckHyperlinkHelper.createHyperlinksByOffset(): guard the whole chain (the injected workbench is optional and may be null) and the active editor before getEditorInput(); fall through to super when null. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rubenporras
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two UI helpers walked
workbench.getActiveWorkbenchWindow().getActivePage()…with no null checks, NPEing when there's no active window/page/editor:PlatformPluginAwareEditorOpener.open()— the page lookup was outside thetry, so the NPE escaped theIDE.openEditorerror handling. Now guardsgetActiveWorkbenchWindow()(matching the in-filegetProjectName()sibling) and falls back to thesuper.open()result when null.CheckHyperlinkHelper.createHyperlinksByOffset()— guards the whole chain (the injectedworkbenchis@Inject(optional = true), so nullable) and the active editor beforegetEditorInput(); falls through tosuperwhen null.Found by a repo-wide inconsistency sweep.
🤖 Generated with Claude Code